Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the URL from the Broker.Status instead of hardcoding it for upgrade tests #3174

Closed
cardil opened this issue May 20, 2020 · 1 comment · Fixed by #3184
Closed

Fetch the URL from the Broker.Status instead of hardcoding it for upgrade tests #3174

cardil opened this issue May 20, 2020 · 1 comment · Fixed by #3184
Assignees

Comments

@cardil
Copy link
Contributor

cardil commented May 20, 2020

Problem
PR #2388 introduce an upgrade tests. In those I utilize feeding events directly to a broker. At that time there was only ChannelBasedBroker. Now, it will be removed. We should fetch the URL of the broker from the Broker.Status field instead of hardcoding it in:

address = 'http://default-broker.{{- .Namespace -}}.svc.cluster.local'

Persona:
Which persona is this feature for? Contributors

Exit Criteria
Done if the broker address is no longer hard coded in source code.

Time Estimate (optional):
4h

Additional context (optional)
As noticed by @vaikas in #2388 (comment)

@cardil
Copy link
Contributor Author

cardil commented May 20, 2020

/assign @cardil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant