Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All the controller container names should be called controller #3048

Closed
aliok opened this issue Apr 25, 2020 · 1 comment
Closed

All the controller container names should be called controller #3048

aliok opened this issue Apr 25, 2020 · 1 comment
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@aliok
Copy link
Member

aliok commented Apr 25, 2020

Problem
Image override within operator is problematic at the moment.
Some containers have the same names. Some have different name but their pattern is also different.

I proposed making all container names unique at #2794 but that looks like is not the way to go.

However, to be consistent, let's make all controller container names controller.
This is less confusing when we're doing image overrides with the operator.

Persona:
System Integrator

Exit Criteria
All containers have the same name

Time Estimate (optional):
1d

Additional context (optional)
If we agree doing this, we should also do it for serving.

cc @jcrossley3 @houshengbo

@grantr grantr added area/test-and-release Test infrastructure, tests or release priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/good-first-issue Denotes an issue ready for a new contributor. labels Apr 27, 2020
@grantr grantr added this to the Backlog milestone Aug 24, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants