From f793c398592978c58848731175b61a9689505c18 Mon Sep 17 00:00:00 2001 From: Doug Davis Date: Mon, 18 Mar 2019 19:41:39 -0700 Subject: [PATCH] Set memory limits We're seeing OOM issues at the Node level when we don't set the limit on some pods. This will allow the pod to restart gracefully w/o taking down the entire node. I'm not stuck on the specific value so we can pick a different one. See https://github.com/knative/serving/pull/3332 for the serving equivalent. Signed-off-by: Doug Davis --- config/500-controller.yaml | 3 +++ config/500-webhook.yaml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/config/500-controller.yaml b/config/500-controller.yaml index 3cc82cb672c..f1466e1a55a 100644 --- a/config/500-controller.yaml +++ b/config/500-controller.yaml @@ -52,6 +52,9 @@ spec: ports: - containerPort: 9090 name: metrics + resources: + limits: + memory: 1000Mi # An initial guess, but consistent with serving volumeMounts: - name: config-logging mountPath: /etc/config-logging diff --git a/config/500-webhook.yaml b/config/500-webhook.yaml index bdfac3af651..c1aa0acc376 100644 --- a/config/500-webhook.yaml +++ b/config/500-webhook.yaml @@ -46,6 +46,9 @@ spec: fieldPath: metadata.namespace - name: CONFIG_LOGGING_NAME value: config-logging + resources: + limits: + memory: 1000Mi # An initial guess, but consistent with serving volumes: - name: config-logging configMap: