From 60c1987acb19173688170fd8b9d175cc910a753a Mon Sep 17 00:00:00 2001 From: Jimmy Lin Date: Fri, 27 Nov 2020 16:34:06 -0500 Subject: [PATCH] Resolve comments --- test/performance/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/performance/README.md b/test/performance/README.md index d7edb7397f0..628c6af0681 100644 --- a/test/performance/README.md +++ b/test/performance/README.md @@ -3,11 +3,11 @@ ## Configuring your cluster to run a benchmark 1. Create a namespace `perf-eventing` if not exists. To use a different - namespace, pleaes replace all the namespaces in + namespace, please replace all the namespaces in all bash commands and yaml configuration files with your choice. -1. Install Knative eventing by following the steps in - https://github.com/knative/eventing/blob/2c6bf0526634804b7ebeee686445901440cc8edd/test/performance/performance-tests.sh#L31 +1. Install Knative eventing and components used in the performance test, + such as MT broker, by following the steps in https://github.com/knative/eventing/blob/master/DEVELOPMENT.md. 1. Create a ConfigMap called `config-mako` in your chosen namespace containing the Mako config file. @@ -60,7 +60,7 @@ To run a benchmark once, and use the result from `mako-stub` for plotting: 1. Retrieve results from mako-stub using the script in [knative/pkg](https://github.com/knative/pkg/blob/master/test/mako/stub-sidecar/read_results.sh) - where `pod_name` is the name of the aggreator pod: + where `pod_name` is the name of the aggregator pod: ``` bash "$GOPATH/src/knative.dev/pkg/test/mako/stub-sidecar/read_results.sh" "$pod_name" perf-eventing ${mako_port:-10001} ${timeout:-120} ${retries:-100} ${retries_interval:-10} "$output_file"