From 163dab1edfb02f8a976d80724ef7189e115c0e1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20Th=C3=B6mmes?= Date: Wed, 9 Sep 2020 22:31:50 +0200 Subject: [PATCH] Remove 'master' where not necessary and add tracking issues. (#4022) --- pkg/adapter/v2/cloudevents_test.go | 6 +++--- test/lib/nodes/nodes.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/adapter/v2/cloudevents_test.go b/pkg/adapter/v2/cloudevents_test.go index 61e4561f487..d158993e388 100644 --- a/pkg/adapter/v2/cloudevents_test.go +++ b/pkg/adapter/v2/cloudevents_test.go @@ -32,7 +32,7 @@ type mockReporter struct { } var ( - fakeMasterURL = "test-source" + fakeURL = "test-source" ) func (r *mockReporter) ReportEventCount(args *source.ReportArgs, responseCode int) error { @@ -70,7 +70,7 @@ func TestNewCloudEventsClient_send(t *testing.T) { } for n, tc := range testCases { t.Run(n, func(t *testing.T) { - ceClient, err := NewCloudEventsClient(fakeMasterURL, tc.ceOverrides, &mockReporter{}) + ceClient, err := NewCloudEventsClient(fakeURL, tc.ceOverrides, &mockReporter{}) if err != nil { t.Fail() } @@ -125,7 +125,7 @@ func TestNewCloudEventsClient_request(t *testing.T) { } for n, tc := range testCases { t.Run(n, func(t *testing.T) { - ceClient, err := NewCloudEventsClient(fakeMasterURL, tc.ceOverrides, &mockReporter{}) + ceClient, err := NewCloudEventsClient(fakeURL, tc.ceOverrides, &mockReporter{}) if err != nil { t.Fail() } diff --git a/test/lib/nodes/nodes.go b/test/lib/nodes/nodes.go index a4259eca7b2..1418ad24f1a 100644 --- a/test/lib/nodes/nodes.go +++ b/test/lib/nodes/nodes.go @@ -58,7 +58,7 @@ func (n *NodesClient) RandomWorkerNode() (*corev1.Node, error) { " it must be a worker (Minikube, CRC)", node.Name) return &node, nil } else { - role := "master" + role := "master" // see https://github.com/kubernetes/kubeadm/issues/2200 for replacement. n.logger.Infof("Filtering %d nodes, to not contain role: %s", nodesCount, role) workers := FilterOutByRole(nodes.Items, role) n.logger.Infof("Found %d worker(s)", len(workers))