Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Custom Kafka Topics #5607

Closed
Cali0707 opened this issue Jun 22, 2023 · 3 comments · Fixed by #5622
Closed

Document Custom Kafka Topics #5607

Cali0707 opened this issue Jun 22, 2023 · 3 comments · Fixed by #5622
Assignees

Comments

@Cali0707
Copy link
Member

What is changing? (Please include as many details as possible.)

In the Eventing Kafka Broker, we will soon support users being able to define custom topic templates for their kafka topics for Brokers and Channels.

How will this impact our users?

Users will be able to define custom topic templates for their brokers and channels when using the eventing kafka broker. However, users will need to be cautious when upgrading, and ensure that all of their Channels have been given a Status.Annotation for the kafka topic before changing the channel topic template. This is because we are not currently recording the existing topic being used on the channel, and if the template is changed before we have recorded this then the Channel will create a new topic following the new template.

In what release will this take happen (to the best of your knowledge)?

Context

Link to associated PRs or issues from other repos here.

  1. Allow defining topic prefix for Kafka Broker and KafkaChannel knative-extensions/eventing-kafka-broker#3153
  2. Update Broker and Controller to use topic name templates knative-extensions/eventing-kafka-broker#3162
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 6, 2023

/assign

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2023
@Cali0707
Copy link
Member Author

Cali0707 commented Oct 5, 2023

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant