-
Notifications
You must be signed in to change notification settings - Fork 159
Migrate to reconciler pattern for Build #446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imjasonh: 0 warnings.
In response to this:
Fixes #393
Proposed Changes
- Copy code out of
pkg/controller/build/
and intopkg/reconciler/build/
- Make tests pass
- That's pretty much it.
This is a smaller, more mechanical change than #420 which attempted to roll in a refactor which would have let us drop
builder.Interface
. I'd still like to get rid of that abstraction and just always interact with akubeClient
(which might be fake in tests), but I'll get to that some time after 0.2./assign shashwathi
/assign mattmoorRelease Note
Migrate to reconciler pattern for Build
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I definitely like the scope of this PR. Great work @imjasonh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, @imjasonh! Glad to see Build picking this up!
/lgtm
/approve
/hold
Hold for one nit, if you want to address it now. If not, cancel the hold. I understand this is just the first step :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on pkg/.
|
/hold cancel |
/lgtm |
* Move controller -> reconciler * Fix tests * update-codegen * now with updated dep-collector * Reverse IsDone condition * Remove another indentation
* Move controller -> reconciler * Fix tests * update-codegen * now with updated dep-collector * Reverse IsDone condition * Remove another indentation
* Move controller -> reconciler * Fix tests * update-codegen * now with updated dep-collector * Reverse IsDone condition * Remove another indentation
Fixes #393
Proposed Changes
pkg/controller/build/
and intopkg/reconciler/build/
This is a smaller, more mechanical change than #420 which attempted to roll in a refactor which would have let us drop
builder.Interface
. I'd still like to get rid of that abstraction and just always interact with akubeClient
(which might be fake in tests), but I'll get to that some time after 0.2./assign shashwathi
/assign mattmoor
Release Note