Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GenerateFixedName with kmeta.ChildName #42

Closed
odacremolbap opened this issue Mar 29, 2020 · 0 comments · Fixed by #43
Closed

Replace GenerateFixedName with kmeta.ChildName #42

odacremolbap opened this issue Mar 29, 2020 · 0 comments · Fixed by #43

Comments

@odacremolbap
Copy link

As mentioned here:

GenerateFixedName should be deprecated and kmeta.ChildName used instead.

https://github.com/knative/sample-source/blob/b93378f82933237f1125f02d716f607820a6bf93/pkg/reconciler/sample/resources/receive_adapter.go#L47

To replace a line like:

utils.GenerateFixedName(args.Source, fmt.Sprintf("samplesource-%s", args.Source.Name))

something like this should work:

kmeta.ChildName(fmt.Sprintf("samplesource-%s-", args.Source.Name), string(args.Source.GetUID())),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace util.GenerateFixedname with kmeta.ChildName odacremolbap/sample-source
1 participant
@odacremolbap