Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to support batch events sending #438

Closed
gabo1208 opened this issue Sep 28, 2021 · 6 comments
Closed

Do we want to support batch events sending #438

gabo1208 opened this issue Sep 28, 2021 · 6 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@gabo1208
Copy link
Contributor

We need to decide if we want to support the CloudEvents batch format or not, and the implement it.

@benmoss
Copy link
Contributor

benmoss commented Sep 30, 2021

knative/eventing#4409 I don't think eventing generally supports the json batch format

@gabo1208
Copy link
Contributor Author

Yeah this is like a thought of mine based on a TODO, but the solution should be to wait for the sockets implementation?

@evankanderson
Copy link
Contributor

I'd prioritize HTTP/2 support first, then measure the improvement batch provides.

@evankanderson
Copy link
Contributor

Rationale: HTTP/1.1 Is likely encumbered by a lot of TCP setup/teardown per request, which probably imposes substantial overhead. HTTP/2 allows multiplexing requests over a single TCP pipe for the cost of a library change for clients. Adding batch delivery support requires restructuring code vs current implementations, so has a higher ecosystem cost.

@gabo1208
Copy link
Contributor Author

gabo1208 commented Oct 4, 2021

Nice! Supper clear, thanks @evankanderson

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
@github-actions github-actions bot closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants