Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Enhanced Trigger Filters field #1434

Open
Cali0707 opened this issue Jul 9, 2024 · 2 comments
Open

Support the Enhanced Trigger Filters field #1434

Cali0707 opened this issue Jul 9, 2024 · 2 comments
Labels
broker+trigger kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jul 9, 2024

Problem
In eventing core and the kafka broker implementation, we have added support for a new filters field which provides more comprehensive event filtering than the current filter field. It would be good to add this to the RabbitMQ broker as well so that we can support this filtering across all broker implementations.

Persona:
Which persona is this feature for? Developers

Exit Criteria
The e2e tests from eventing core for the new trigger filters pass

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 2

Additional context (optional)
Add any other context about the feature request here.

The core issue is knative/eventing#5204

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 9, 2024

@ikavgo if you think this makes sense I'm happy to contribute a PR :)

Copy link

github-actions bot commented Oct 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broker+trigger kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant