Feature autocomplete-select onChange #1466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3dr0x
changed the title
c3dr0x
changed the title
Hartorn
force-pushed
the
feature-autocomplete-onChange
branch
from
d587f40 to
cd0dd68
Compare
|
@c3dr0x I rebased it, and made some changes : _setValue needs the whole props value, to have latest keyresolver and so on. Still need to test it, but static analyse looks good |
c3dr0x
force-pushed
the
feature-autocomplete-onChange
branch
from
cd0dd68 to
481fa52
Compare
c3dr0x
force-pushed
the
feature-autocomplete-onChange
branch
from
481fa52 to
6508d9d
Compare
wholeItem change the value being managed by component from itemKey to item
c3dr0x
force-pushed
the
feature-autocomplete-onChange
branch
from
6508d9d to
9128e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Component] Autocomplete-select
Fix #1448
Description
Add a new option prop :
wholeItem.Setting it to
truewill change the behavior of component to manage in value, the whole item instead of its key. Same goes foronChangemethod.Breaking change
If the override
renderOptionsmethod is used, then it should be updated because now theoptionswithin state contains items and not items' labels.