Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

refactor: send raw tx bytes to eth_send_raw_unsigned_transaction #943

Closed
enitrat opened this issue Sep 13, 2024 · 0 comments · Fixed by #1015
Closed

refactor: send raw tx bytes to eth_send_raw_unsigned_transaction #943

enitrat opened this issue Sep 13, 2024 · 0 comments · Fixed by #1015
Assignees
@enitrat
Labels
enhancement New feature or request

Comments

@enitrat
Copy link
Contributor

enitrat commented Sep 13, 2024

Refactor the execution flow from an account to:

  • Only validate the hash of the transaction bytes considering the signature of the tx
  • Send the raw tx bytes to eth_send_raw_unsigned_transaction
  • Inside eth_send_raw_unsigned_transaction, we can deserialize the bytes into a Transaction type directly, because we no longer need the transaction hash during the execution of a Tx
  • As such, TransactionUnsigned can be deleted, only Transaction will be kept.
@enitrat enitrat added the enhancement New feature or request label Sep 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 13, 2024
@enitrat enitrat self-assigned this Oct 4, 2024
@enitrat enitrat mentioned this issue Oct 4, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot on Starknet Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@enitrat enitrat

Labels
enhancement New feature or request
Projects
No open projects
Kakarot on Starknet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: eth_send_raw_transaction kkrt-labs/kakarot-ssj
1 participant
@enitrat