Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

feat: use get_starknet_address #928

Closed
enitrat opened this issue Sep 12, 2024 · 1 comment · Fixed by #1018
Closed

feat: use get_starknet_address #928

enitrat opened this issue Sep 12, 2024 · 1 comment · Fixed by #1018
Labels
enhancement New feature or request

Comments

@enitrat
Copy link
Contributor

enitrat commented Sep 12, 2024

  • compute_starknet_address returns the value computed for an EVM address based on the uninitialized class hash
  • address_registry returns the value stored in the Kakarot_evm_to_starknet_address storage var

We introduced in KakarotZero a get_evm_address entrypoint that reads the address registry, and if no entry, computes the evm address.

Use it throughout the codebase instead of compute_starknet_address.

@enitrat enitrat added the enhancement New feature or request label Sep 12, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 12, 2024
@enitrat enitrat changed the title feat: implement get_evm_address feat: implement get_starknet_address Sep 12, 2024
@adrianvrj
Copy link
Contributor

hey @enitrat do you need help with this one?

@enitrat enitrat changed the title feat: implement get_starknet_address feat: use get_starknet_address Sep 13, 2024
@enitrat enitrat mentioned this issue Oct 4, 2024
9 tasks
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot on Starknet Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants