bug: mismatch expected nonce in collision tests

[ftupas]

Bug Report

Kakarot version: kkrt-labs/kakarot@0c6e7a6

Current behavior:
Tests for SSTORE provided by ethereum/tests fails during the following tests when transactions are expected to pass

Test Name	Actual	Expected
InitCollision_d0g0v0_Shanghai	0x0000000000000000000000000000000000000000000000000000000000000000	0x0000000000000000000000000000000000000000000000000000000000000001
InitCollisionNonZeroNonce_d0g0v0_Shanghai	0x0000000000000000000000000000000000000000000000000000000000000000	0x0000000000000000000000000000000000000000000000000000000000000001

Instead they are all failing with mismatch on expected nonce

Expected behavior:
Test should pass.

Steps to reproduce:

• clone ef-tests: https://github.com/kkrt-labs/ef-tests
• generate katana dump of kakarot system and move the .katana folder to your ef-tests directory
• run the following

make setup
make target=InitCollision_d0g0v0_Shanghai ef-test

Failing output should be:

Test failed: failed test InitCollision_d0g0v0_Shanghai: expected nonce 0x0000000000000000000000000000000000000000000000000000000000000001, got 0x0000000000000000000000000000000000000000000000000000000000000000

Tasks

Beta Give feedback

1. Fix handling pre-state to create contract accounts when account has storage #41
   bug runner bug +2
   
2. bug: contract account nonce is not incremented since it is using protocol-level nonce kakarot#715
   Type: bug +1
   
3. feat: update nonce to return managed nonce for contract accounts kakarot-rpc#502
   new-feature +1
   
4. Update post-state assertion for nonce depending on type of account #45
   +0
   

[ftupas]

With @ClementWalter , we have done the following

• realize that this tx is a create tx
• use this util to compute the target address
• confirmed resulting address is 0x6295ee1b4f6dd65047762f924ecd367c17eabf8f
• this is a pre-deployed contract account
• contract account nonce are not stored in the sequencer nonce storage
• we need to check the managed nonce instead

Another problem

• we realize that this has been pre-deployed as an eoa instead of a contract account, see here
• we need to fix how we handle the pre-state for the accounts

Next steps

In handle_post_state:

• if the account we are asserting against is an EOA, we use protocol-level nonce
• if it's a contract account, we use the managed nonce

In write_test_state:

• Check if the account has storage as well, not just code
• Update these lines to include this logic

Appendix

• Types of Account