-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemaps generating unexpected sitemaps path for AwsSdkAdapter #279
Comments
You're right, there's a bug in the Can you try creating your adapter like so: That should avoid the issue until I can fix it. I didn't actually write that code. But I shouldn't have let a hard-coded path through the cracks :/ |
Yup that fixed it! No worries, thanks for the suggestion. |
👍 -- thanks for posting this |
This is fixed in v6.0.0 of the gem, you can remove this workaround. |
I'm using the following settings with the AwsSdk Adapter for creating my stiemaps:
SitemapGenerator::Sitemap.default_host = "https://www.mysite.com"
SitemapGenerator::Sitemap.create_index = true
SitemapGenerator::Sitemap.sitemaps_host = "https://s3-us-west-2.amazonaws.com/mysite-assets/"
SitemapGenerator::Sitemap.sitemaps_path = "sitemaps/"
SitemapGenerator::Sitemap.adapter = SitemapGenerator::AwsSdkAdapter.new('mysite-assets')
However, this is generating the sitemaps in https://s3-us-west-2.amazonaws.com/mysite-assets/sitemaps/sitemaps/ so that there is an extra sitemaps/ subdirectory created. I can remove the SitemapGenerator::Sitemap.sitemaps_path = "sitemaps/" line, but that causes the search engines to incorrectly ping for the sitemaps in https://s3-us-west-2.amazonaws.com/mysite-assets/ instead of https://s3-us-west-2.amazonaws.com/mysite-assets/sitemaps/
The text was updated successfully, but these errors were encountered: