Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest C++14 requirement (move to C++17) #877

Closed
xvitaly opened this issue Jan 30, 2023 · 4 comments · Fixed by #996
Closed

gtest C++14 requirement (move to C++17) #877

xvitaly opened this issue Jan 30, 2023 · 4 comments · Fixed by #996

Comments

@xvitaly
Copy link
Contributor

xvitaly commented Jan 30, 2023

Google Test since version 1.13.0 requires C++14:

[4/69] g++ -Itest/tagParsing.p -Iinclude -I../include -I/usr/include/p11-kit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++11 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -DGTEST_HAS_PTHREAD=1 -pthread -MD -MQ test/tagParsing.p/tagParsing.cpp.o -MF test/tagParsing.p/tagParsing.cpp.o.d -o test/tagParsing.p/tagParsing.cpp.o -c ../test/tagParsing.cpp
FAILED: test/tagParsing.p/tagParsing.cpp.o 
g++ -Itest/tagParsing.p -Iinclude -I../include -I/usr/include/p11-kit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++11 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -DGTEST_HAS_PTHREAD=1 -pthread -MD -MQ test/tagParsing.p/tagParsing.cpp.o -MF test/tagParsing.p/tagParsing.cpp.o.d -o test/tagParsing.p/tagParsing.cpp.o -c ../test/tagParsing.cpp
In file included from /usr/include/gtest/gtest-message.h:57,
                 from /usr/include/gtest/gtest-assertion-result.h:46,
                 from /usr/include/gtest/gtest.h:64,
                 from ../test/tagParsing.cpp:20:
/usr/include/gtest/internal/gtest-port.h:270:2: error: #error C++ versions less than C++14 are not supported.
  270 | #error C++ versions less than C++14 are not supported.
      |  ^~~~~
@kelson42 kelson42 added this to the 12.1.0 milestone Jan 30, 2023
@kelson42
Copy link
Collaborator

@xvitaly I guess this could make the packaging difficult if we don't move?
@mgautierfr @veloman-yunkan Any challenge to implement/fix?

@xvitaly
Copy link
Contributor Author

xvitaly commented Jan 30, 2023

I guess this could make the packaging difficult if we don't move?

All tests will start to fail after updating gtest to version 1.13.

We used a temporary workaround %meson -Dcpp_std=c++14. It builds without issues.

@kelson42 kelson42 changed the title gtest C++14 requirement gtest C++17 requirement Feb 6, 2023
@kelson42 kelson42 changed the title gtest C++17 requirement gtest C++14 requirement (move to C++17) Feb 6, 2023
@kelson42 kelson42 modified the milestones: 12.1.0, 12.2.0 Feb 6, 2023
@kelson42
Copy link
Collaborator

kelson42 commented Apr 1, 2023

Blocked by kiwix/kiwix-build#587

@kelson42
Copy link
Collaborator

Depends on kiwix/kiwix-build#598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment