Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-hiding of the taskbar in the iframe-based viewer #820

Closed
veloman-yunkan opened this issue Sep 22, 2022 · 1 comment · Fixed by #821
Closed

Auto-hiding of the taskbar in the iframe-based viewer #820

veloman-yunkan opened this issue Sep 22, 2022 · 1 comment · Fixed by #821
Assignees
@veloman-yunkan
Labels
bug
Milestone
12.0.0

Comments

@veloman-yunkan
Copy link
Collaborator

Introduction of iframe-based viewer (#716) broke the auto-hiding functionality of the taskbar. Auto hiding (enabled for narrow-screens) works correctly only for the first page loaded in the viewer. Navigating to other pages interferes with auto-hiding as follows:

  • If the toolbar was hidden, it stays hidden.

  • If the toolbar was not hidden, it loses the ability to auto-hide.
@veloman-yunkan veloman-yunkan self-assigned this Sep 22, 2022
@veloman-yunkan veloman-yunkan mentioned this issue Sep 22, 2022
Merged
@kelson42 kelson42 added the bug label Sep 22, 2022
@kelson42
Copy link
Collaborator

We should fix that, not having a top ar is a serious regression IMO.

@kelson42 kelson42 added this to the 12.0.0 milestone Sep 22, 2022
@veloman-yunkan veloman-yunkan mentioned this issue Sep 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veloman-yunkan veloman-yunkan

Labels
bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

Auto-hiding of the iframe-based taskbar kiwix/libkiwix
2 participants
@kelson42 @veloman-yunkan