New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper usage of `Searcher::getResults(start, end)` #595

Closed

maneeshpm opened this issue Jul 29, 2021 · 0 comments · Fixed by #597

Assignees

Labels

bug kiwix-serve search

Milestone

Contributor

maneeshpm commented Jul 29, 2021

Following openzim/libzim#596, we have some fixes to make in the internal server

eg. We always calculate end = start + pageLength, and then call getResults(start, end). But it should rather be getResults(start, pageLength)

maneeshpm added bug kiwix-serve search labels

maneeshpm self-assigned this

maneeshpm mentioned this issue

Allow kiwix-serve to get suggestions of custom range #591

Merged

kelson42 modified the milestones: 10.0.1, 10.0.0

maneeshpm mentioned this issue

Fix usage of zim::Searcher::getResults() in libkiwix #597

Merged

mgautierfr closed this as completed in #597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment