Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kiwix-serve welcome page doesn't account for --urlRootLocation #589

Closed
veloman-yunkan opened this issue Jul 24, 2021 · 2 comments · Fixed by #590
Closed

Kiwix-serve welcome page doesn't account for --urlRootLocation #589

veloman-yunkan opened this issue Jul 24, 2021 · 2 comments · Fixed by #590
Assignees
@MananJethwani
Labels
bug kiwix-serve
Milestone
10.0.0

Comments

@veloman-yunkan
Copy link
Collaborator

When kiwix-serve is started with the --urlRootLocation option, the welcome page is broken:

  1. Icons in the book tiles cannot be loaded
  2. The preview link is incorrect
@kelson42 kelson42 added this to the 10.0.0 milestone Jul 24, 2021
@kelson42
Copy link
Collaborator

@MananJethwani Can younplease have a look? I suspect that this regression has been introduced recently with your work around new welcome page.

@MananJethwani
Copy link
Contributor

working on it

@MananJethwani MananJethwani mentioned this issue Jul 24, 2021
Merged
@holta holta mentioned this issue Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MananJethwani MananJethwani

Labels
bug kiwix-serve
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

corrected relative links in preview and icon url kiwix/libkiwix
3 participants
@kelson42 @veloman-yunkan @MananJethwani