Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use language/category API to populate Kiwix Serve filter select boxes #555

Closed
kelson42 opened this issue Jun 13, 2021 · 2 comments · Fixed by #600
Closed

Use language/category API to populate Kiwix Serve filter select boxes #555

kelson42 opened this issue Jun 13, 2021 · 2 comments · Fixed by #600
Assignees
@MananJethwani
Labels
enhancement good first issue kiwix-serve
Milestone
10.0.0

Comments

@kelson42
Copy link
Collaborator

@veloman-yunkan has implemented category and language API end points, see:

Current Kiwix Serve filter select boxes choces are hardcoded, we should use the newly created end-points to:

  • Avoid code duplication
  • Provide less useless choices (the end points provide values matching ZIM files in its catalog)
  • Benefit of language localisation (at least for category end-point), one time this will be implemented (see Dump the version to 0.2.0 #59)
@kelson42 kelson42 added this to the 10.0.0 milestone Jun 13, 2021
@kelson42 kelson42 mentioned this issue Jul 28, 2021
Merged
@kelson42
Copy link
Collaborator Author

@MananJethwani Would you be able to implement this ticket now that #553 seems (almost) ready?

@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 3, 2021

No blocker anymore to implement this as all the depending PRs have been merged now.

@MananJethwani MananJethwani mentioned this issue Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MananJethwani MananJethwani

Labels
enhancement good first issue kiwix-serve
Projects
None yet
Milestone
10.0.0
2 participants
@kelson42 @MananJethwani