-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiwix-serve: Language filter of zim list on welcome page #519
Comments
@sharun-s Thank you for your ticket. I think the feature request is great, but pretty much disagree with the way of doing it. This should go through the backend. |
Ah I see you referenced the issue on the "web" repo...I remember seeing that issue and kept searching for it, but couldn't remember on which repo it was on. Too many repos and issue trackers! And yup agree fix should be in the kiwix-serve code. I tried building to patch, but ran into some pkg-config issues. My Ubuntu system recently upgraded from 16 to 18 and something went haywire. Will try again sometime after resolving that. |
@sharun-s FYI, the OPDS backend provides now a way to filter by language see http://wiki.kiwix.org/wiki/OPDS#End_points. The way to implement that feature is IMO to make the whole rendering of books boxes based on the OPDS backend. |
Thanks. Will check it out. |
Would be good as well that:
|
Mass Market / commercial UI's often put very common "Quick Pick" languages on top of long drop-down / pop-up menus that ask you to pick among many languages. e.g. highlighting EN/ES/FR at minimum...or sometimes a subset of 5-to-10 frequent languages, possibly including Portuguese/Chinese/Hindi/Arabic/Russian/Swahili? With most all the other ~200 languages being buried down there in "alphabetical order", as PR #534 today implements. Recap: Should PR #534 or its successors possibly consider "Quick Pick" languages at the top of the Languages drop-down menu? Aside: Pre-selecting the browser's default language is a great idea (as mentioned above) in combination with any such UI! |
I added a little bookmarklet to inject a language filter dropdown to filters zims on the library.kiwix.org site. It could probably work as is in a jquery ready function in home.html.tmpl. Unfamiliar with kiwix-tools and the build/test process to figure out how to submit this as a pr. So pasting code here...after library.kiwix.org loads just paste it into the dev console to see it in action...
The text was updated successfully, but these errors were encountered: