-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiwix-serve random feature returns partly broken URLs #441
Comments
@mgautierfr The problem here is quite fundamental and is related to URL escaping function, but these functions are not in cause here. The problem is that you can not apply to the whole path escaping properly, you need to apply to each part (namespace, zim url) differently... at the kiwix-serve/kiwix-lib level, you don't have this information anymore! |
@mgautierfr Moving the random feature in the libzim should help fixing this bug properly right? |
No, the random feature in libzim will just keep a random entry in the zim file. (I'm moving the issue in kiwix-lib repository) |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@mgautierfr I would need a full analysis of the problem/fix here. |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
This issue seems to be a special case of #775 |
@veloman-yunkan My guess as well. |
With a ZIM with the article
?_(album_de_Nena)
from WPFR. The random button returns the following URL: http://localhost:8080/wikipedia_fr_articles_2019-07/A/?_(album_de_Nena) and it should return http://localhost:8080/wikipedia_fr_articles_2019-07/A/%3F_(album_de_Nena).The text was updated successfully, but these errors were encountered: