-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kiwix-serve raises 500 error on Or
search term
#1104
Comments
The problem here is that the search text is interpreted as a Xapian query where There are different ways to address this issue:
|
This issue remember me of kiwix/kiwix-tools#440, I need to make a reassessment of all of this. |
@veloman-yunkan Solution (1) - so a kind of xapian_escaping() should be implemented, but this should be done IMHO:
For Kiwix serve, not sure exactly how it should be done... but I guess this problem is potentialy everywhere |
@kelson42 The problem is in the catalog search (rather than in ZIM search) so it should be constrained to BTW, note that solution (1) won't fix the outcome of the API call from the description of this PR - it would rather make sure that the search form doesn't generate such API requests. |
@veloman-yunkan Thank you for the clarification, it changes a bit my opinion indeed
I have also a bit of a hard time why you think fixing the form will solve the API, the API can be called from anyway so just fixing the form seems to be fixing the problem at the wrong place to me. |
I never said that. My remark, on the contrary, was intended to emphasize once more that solution (1) is limited to the front end and leaves the API intact. |
That's solution (2). By implementing it we will take away some power from the current operation of the |
@veloman-yunkan Yes, indeed so we won't be able to use Xapian reserved keywords for this specific API end-points. This is basically the only "bad" consequence? |
@kelson42 Yes |
See e.g. https://library.kiwix.org/catalog/v2/entries?start=0&count=4&lang=fra&category=other&q=Or
The text was updated successfully, but these errors were encountered: