-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kiwix-serve does not support IPv6 #545
Comments
I confirm, this is a current limitation ; but ipv6 is pretty rare in local networks. |
No IPv6 is the latest IP version and is widely used already. |
It seem libmicrohttp can support both ipv4 and ipv6 at the same time or only ipv6 or only ipv4. See https://www.gnu.org/software/libmicrohttpd/manual/html_node/microhttpd_002dconst.html. We have to choose the way how to go forward. Being cautious, I tend to think that having first an opion —ipv6 or -6 would be the best approach. |
@kelson42 Can I work on this? |
Yes, if you have a plan how to implement it. |
I'll proceed by adding ipv6 support in libkiwix, then proceed with kiwix-tools. |
If I understood it correctly MHD_USE_DUAL_STACK flag will allow us to receive both ipv4 and ipv6 clients. Regarding, plan of action:
What do you think? |
@aryanA101a Have you considered all options? How they shoukd work? |
I think that's not an appropriate solution. Since, we cannot assume that everyone has ipv6 support in their system as The better plan of action would be:
|
Q1. If INADDR_ANY is defined as 0, why are we checking if it is unequal to zero?
Is it the intended behavior ? |
|
I would say that we want to support potential system where INADDR_ANY would not be defined to 0. In this case, we have to use this value, what ever it is.
We want to tell to the user on which IP address they can connect. |
how to build kiwix-tools for windows? |
@mgautierfr ? With kiwix build? |
kiwix-build is giving error. OS: Fedora 39
|
Do I proceed on to open a pr to add |
@aryanA101a Not sure honestly, do like you think is right. What I'm sure, is that this is a bad idea to discuss in length Kiwix build topics here. |
Copying my comment from the PR review:
|
The text was updated successfully, but these errors were encountered: