Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page of very recent TED Talks and YouTube-based ZIMs improperly displayed #297

Closed
Jaifroid opened this issue Sep 28, 2022 · 2 comments
Assignees
Labels
bug fixed Fixed, awaiting publication in new apps regression
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Sep 28, 2022

Unfortunately this regression has crept in due to the fix to TED, YouTube and Nautilus-based ZIM archives, and wasn't caught before release. The same fix as was implemented in the app for Nautilus needs to be applied more generically to YouTube-based ZIMs. The landing page of Type 1 (no-namespace) TED and YouTube-based ZIMs released since around June is broken in all Kiwix JS Windows and Linux apps in version 2.1.8 and below. Older Type 0 TED and YouTube ZIMs are not affected by this bug.

@Jaifroid Jaifroid added this to the Release 2.2.0 milestone Sep 28, 2022
@Jaifroid Jaifroid self-assigned this Sep 28, 2022
@Jaifroid Jaifroid added the fixed Fixed, awaiting publication in new apps label Sep 28, 2022
@Jaifroid Jaifroid changed the title Landing page of TED Talks ZIMs improperly displayed in v2.1.8 Landing page of TED Talks ZIMs improperly displayed Sep 28, 2022
@Jaifroid
Copy link
Member Author

This bug was actually a side-effect interacting with a latent bug. A bug was triggered once inline JavaScript was removed in openzim/youtube#154. The ZIMs in question have an odd dependency, in their JavaScript, on reading a favicon in the page's source code in order to discover the ZIM directory. The favicon's href was temporarily removed as part of preloading stylesheets, which was unnecessary for this ZIM type, but which did no harm in the older ZIMs with inline JS. It is exactly the same situation documented in openzim/nautilus#40 for Nautilus-style ZIMs. See in particular openzim/nautilus#40 (comment).

@Jaifroid
Copy link
Member Author

Jaifroid commented Sep 29, 2022

A fix is in 50fe0bb and has been released to the PWA app v2.1.81. Because the Store app in SW mode depends on the PWA, then the Store app is also fixed. So, only the Electron and NWJS apps continue to be affected, and these will be updated in the next intermediate release. Issue will stay open till full release.

@Jaifroid Jaifroid changed the title Landing page of TED Talks ZIMs improperly displayed Landing page of very recent TED Talks and YouTube-based ZIMs improperly displayed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed Fixed, awaiting publication in new apps regression
Projects
None yet
Development

No branches or pull requests

1 participant