From 63b9de95855d4357541e2c6db3ec8c0f50e5cbf3 Mon Sep 17 00:00:00 2001 From: Nikhil Tanwar <2002nikhiltanwar@gmail.com> Date: Thu, 3 Aug 2023 09:10:54 +0530 Subject: [PATCH] Do index check before access in contextmenu Fix #971 --- src/contentmanager.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/contentmanager.cpp b/src/contentmanager.cpp index 5be499b8..60c0e6f3 100644 --- a/src/contentmanager.cpp +++ b/src/contentmanager.cpp @@ -90,6 +90,8 @@ QList> ContentManager::getBooksList() void ContentManager::onCustomContextMenu(const QPoint &point) { QModelIndex index = mp_view->getView()->indexAt(point); + if (!index.isValid()) + return; QMenu contextMenu("optionsMenu", mp_view->getView()); auto bookNode = static_cast(index.internalPointer()); const auto id = bookNode->getBookId(); @@ -154,9 +156,7 @@ void ContentManager::onCustomContextMenu(const QPoint &point) resumeBook(id, index); }); - if (index.isValid()) { - contextMenu.exec(mp_view->getView()->viewport()->mapToGlobal(point)); - } + contextMenu.exec(mp_view->getView()->viewport()->mapToGlobal(point)); } void ContentManager::setLocal(bool local) {