Skip to content

lxml recipe doesn't work with Python 3 #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Nov 5, 2018 · 3 comments
Closed

lxml recipe doesn't work with Python 3 #1445

ghost opened this issue Nov 5, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 5, 2018

Versions

  • Python: python3crystax
  • OS: ubuntu in docker
  • Kivy: not used
  • Cython: not relevant

Description

I saw an lxml recipe was recently merged and I'm very interested in that, but sadly it seems to be limited to python2 for some reason. It would be neat if that could be changed!

I already tried changing the dependencies to ("python2", "python3crystax") instead, but something seems to hardcode -lpython2.7 into the linker flags, so it breaks nevertheless.

@AndreMiras
Copy link
Member

Yes true, the pull request #1428 was made it python2 only. The contributor @jerome-poisson didn't have time to investigate on Python3.
Feel free to do so if you can 👍

@ghost
Copy link
Author

ghost commented Nov 5, 2018

The pull request looks different though, it doesn't actually hardcode python2.7 into the linker flags. What happened?

Edit: oh, it's the one for libxml2, not lxml. My bad

@ghost
Copy link
Author

ghost commented Nov 5, 2018

I made a pull request that takes the hacks out: #1446 This makes it work flawlessly with python3crystax, as far as I can tell. It might break Python 2 support, if any of those hacks were actually workarounds to core problems. In that case, that core problems should probably be fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant