Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing import os in jnius/__init__.py - there should be a CI workflow for pyjnius #245

Closed
rhoerbe opened this issue Oct 26, 2016 · 2 comments

Comments

@rhoerbe
Copy link

rhoerbe commented Oct 26, 2016

File "/usr/lib64/python3.4/site-packages/jnius-1.1.dev0-py3.4-linux-x86_64.egg/jnius/init.py", line 42, in
if "ANDROID_ARGUMENT" in os.environ:
NameError: name 'os' is not defined

May I suggest to activate a CI work flow to verify properties of commits and pull requests int he master branch? I have published a basic Travis-CI setup for py 2.7/3.4/3.5 with centos7 in this project:
https://github.com/rhoerbe/pyjnius-deploytest.git
AFAIK Travis can also be used to test android and OSX.

@rhoerbe
Copy link
Author

rhoerbe commented Oct 26, 2016

And could be configured to publish a new version on PyPi once tests are successful.

@akshayaurora
Copy link
Member

@rhoerbe the issue is fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants