Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local recipe support #596

Open
Andrei-Pozolotin opened this issue Mar 13, 2021 · 4 comments
Open

local recipe support #596

Andrei-Pozolotin opened this issue Mar 13, 2021 · 4 comments

Comments

@Andrei-Pozolotin
Copy link

  1. currently there seems to be no way to support a local recipe:

https://github.com/kivy/kivy-ios/blob/2cb084c26b7e9b45b027961cded13521b8db5b6b/kivy_ios/toolchain.py

  1. in a simple way, i.e. how p4a is doing it:

https://github.com/kivy/python-for-android/blob/develop/pythonforandroid/toolchain.py

        generic_parser.add_argument(
            '--local-recipes', '--local_recipes',
            dest='local_recipes', default='./p4a-recipes',
            help='Directory to look for local recipes')
@misl6
Copy link
Member

misl6 commented Mar 14, 2021

If I get it right your request, We already have this feature and it's exposed by --add-custom-recipe.

You can add multiple custom recipes by using it:

python toolchain.py build mycustompackage1 mycustompackage2 --add-custom-recipe /PATH/TO/MY/RECIPE1 --add-custom-recipe /PATH/TO/MY/RECIPE2

@Andrei-Pozolotin
Copy link
Author

@misl6 Mirko:
thank you, I did not see --add-custom-recipe before

a couple of questions, please:

  1. this does not seem to work for custom recipe to override/replace existing/provided recipe?
    for example in order to locally resolve recipes/python3/reduce_python breaks google-auth-library-python-oauthlib via wsgiref #595
toolchain build python3 --add-custom-recipe /path-to/custom-recipe/python3
  1. clean is not supported, then how to clean?
toolchain clean recipe_x --add-custom-recipe /path-to/custom-recipe/recipe_x

@misl6
Copy link
Member

misl6 commented Mar 27, 2021

Hi @Andrei-Pozolotin ,

Yes, it doesn't override an existing recipe and after checking python-for-android code, It probably should do in order to be fully consistent.

Also, clean is not supported and should be.

Leaving that open and marking it as milestone 1.3.0. Thank you for reporting.

@tcaduser
Copy link
Contributor

I am able to add a custom recipe, but it was not getting installed onto the app. To do this I had to move the recipe from my local directory into the virtual environment of my host python:

$VIRTUAL_ENV/lib/python3.9/site-packages/kivy_ios/recipes/myapp/__init__.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants