Cleanup + Add test in CI for cookiecutter related things

[misl6]

• Removed (and added to requirements.txt file) the un-needed things in tools/external
• Added a CI test case for cookiecutter related things.

[AndreMiras]

Feels good!
So these tools/externals/ were definitely 100% replaceable by the actual pypi modules?
I would simply take a look at the git log of some of them to see if they were maintained to add features used in kivy-ios.
Also having someone else using kivy-ios to cross check before merging would be great

[AndreMiras]

Yes xcassette was maintained, see for instance: f288af5 and f8916b9
So I would say let's not delete this one as it seems kivy-ios custom.
Also we should start unit testing it if we're about to maintain that

[tshirtman]

maybe it could have been a PR against https://github.com/albert-zhang/gen_xcassets

[AndreMiras]

I have really little clue about macOS so I can't tell. But the code base doesn't look the same so at least it wasn't heavily borrowed from there. I would say to keep it simple for now I would simply undelete the tools/external/xcassets.py file. And then definitely if there's a way to use existing maintained/tested thirdparty dependency I would say we should go for it via separate PR

[tshirtman]

true, maybe it's not the correct one, i agree it's simpler to keep this one for now.

[AndreMiras]

misl6 just gave me a heads up on Discord and didn't actually delete it 😅
So I'm good for a merge after another one can take a look

[Zen-CODE]

On checking out the branch:

richard@Richards-MacBook-Pro kivy-ios % python3 toolchain.py build kivy python openssl                         
Traceback (most recent call last):
    File "toolchain.py", line 40, in <module>
    import sh
    ModuleNotFoundError: No module named 'sh'

[Zen-CODE]

So. I'm guessing we need to install those requirements. One issue I have with that is that I've been unable to run the toolchain successfully in a venv. I can only get a successful build using the python version installed via brew. So depending on libraries in the native python install is...a pity.

It would also mean we would need to change installation instructions.

[Zen-CODE]

Even when creating a venv, I get this err. I think there was a reason that these external tools where included in the repo..

[AndreMiras]

The sh requirement is defined already https://github.com/kivy/kivy-ios/pull/454/files#diff-b4ef698db8ca845e5845c4618278f29aR5
Until we fix the venv we can still install the requirements with the --user flag.
You're talking about this issue right? #401
I have some ideas to dig into and I'm confident I could fix, but I need to install macOS first

[Zen-CODE]

@AndreMiras I know it's added to requirements. Please see my comments above. But as I mentioned, the issues are:

• it then needs to be installed into the system python (venv not working)
• the installation instructions need to be updated to specify that.

To be honest, I'd rather live with the ugliness of external/tools that depending on requirements being installed to the systems python. I'd only be happy if a venv could be used....

[AndreMiras]

OK let's keep this pending until we fix the venv then

As agreed with Zen-Code let's fix the venv first

[AndreMiras]

@misl6 could you rebase as #462 got merged?

[AndreMiras]

LGTM, I'll play with it soon.
Ideally we should also remove the second pip install sh from the venv test since it's now part of of the requirements.txt file. It's rather minor and CI builds for ages so I guess it's OK we don't address now.
I will give it a try now see if I can build/run a project without having any of the deps in the system but only in the venv

[AndreMiras]

So far so good, here's what I've done to test it.
I've dropped all my pip dependencies installed outside the venv to test it:

deactivate
pip3 uninstall --yes $(pip3 freeze)

Then I've created a completely new venv to build recipes:

rm -rf venv/ && python3 -m venv venv 
. venv/bin/activate
pip install -r requirements.txt
pip install cython==0.28.1
python toolchain.py build python3 kivy

It built successfully. I'm now about to try on device and merge if it works OK

[AndreMiras]

App ran fine on device simulator nice work!
Thanks for addressing the comments and squashing the commits 🍻