Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android.accept_sdk_license may misbehave #816

Closed
AndreMiras opened this issue Feb 5, 2019 · 2 comments
Closed

android.accept_sdk_license may misbehave #816

AndreMiras opened this issue Feb 5, 2019 · 2 comments
Labels

Comments

@AndreMiras
Copy link
Member

Versions

  • Python:
  • OS:
  • Buildozer: master 205f1f6

Description

I suspect android.accept_sdk_license misbehave such that if it's defined to False in the spec file like android.accept_sdk_license = False. It will be evaluated as True still.
This is because the auto_accept_license = self.buildozer.config.getdefault('app', 'android.accept_sdk_license', False) expression retrieve the string and would return "False" which is evaluated as True in bool, see: https://github.com/kivy/buildozer/blob/a780cc4/buildozer/targets/android.py#L463

Demo:
buildozer.spec must contain android.accept_sdk_license = False
Then from a shell:

>>> from buildozer import Buildozer
>>> buildozer = Buildozer()
# Check configuration tokens
>>> buildozer.config.get('app', 'android.accept_sdk_license')
'False'
>>> bool('False')
True
@AndreMiras
Copy link
Member Author

PR #817

@AndreMiras
Copy link
Member Author

Fixed via #817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant