From 3b1d07d962c8b51c63cc11826ca7ce60bb2ca17a Mon Sep 17 00:00:00 2001 From: Roger Gutierrez Date: Wed, 16 Aug 2023 17:30:36 -0600 Subject: [PATCH 1/2] feat: new loan card added for empty basket state in checkout page --- .../LoansYouMightLike/MinimalLoanCard.vue | 174 ------------------ .../RandomLoanSelector/RandomLoanSelector.vue | 68 +++++-- src/pages/Checkout/CheckoutPage.vue | 1 + 3 files changed, 51 insertions(+), 192 deletions(-) delete mode 100644 src/components/LoansYouMightLike/MinimalLoanCard.vue diff --git a/src/components/LoansYouMightLike/MinimalLoanCard.vue b/src/components/LoansYouMightLike/MinimalLoanCard.vue deleted file mode 100644 index 2df545010d..0000000000 --- a/src/components/LoansYouMightLike/MinimalLoanCard.vue +++ /dev/null @@ -1,174 +0,0 @@ - - diff --git a/src/components/RandomLoanSelector/RandomLoanSelector.vue b/src/components/RandomLoanSelector/RandomLoanSelector.vue index 8dc76b8020..f725a63b0c 100644 --- a/src/components/RandomLoanSelector/RandomLoanSelector.vue +++ b/src/components/RandomLoanSelector/RandomLoanSelector.vue @@ -9,7 +9,6 @@ tw-border-t tw-border-tertiary " - style="min-height: 23rem;" >
@@ -43,7 +42,8 @@ diff --git a/src/pages/Checkout/CheckoutPage.vue b/src/pages/Checkout/CheckoutPage.vue index fa533e4271..7c988a7989 100644 --- a/src/pages/Checkout/CheckoutPage.vue +++ b/src/pages/Checkout/CheckoutPage.vue @@ -246,6 +246,7 @@ style="min-height: 23rem;" > From 4130eb82ed24e7b7d2c46a945fb493aa66c20ab9 Mon Sep 17 00:00:00 2001 From: Roger Gutierrez Date: Thu, 17 Aug 2023 10:38:10 -0600 Subject: [PATCH 2/2] fix: updating totals event restored in checkout empty status --- src/components/LoanCards/KvClassicLoanCardContainer.vue | 2 ++ src/components/RandomLoanSelector/RandomLoanSelector.vue | 1 + 2 files changed, 3 insertions(+) diff --git a/src/components/LoanCards/KvClassicLoanCardContainer.vue b/src/components/LoanCards/KvClassicLoanCardContainer.vue index 293ba01855..e128ed822e 100644 --- a/src/components/LoanCards/KvClassicLoanCardContainer.vue +++ b/src/components/LoanCards/KvClassicLoanCardContainer.vue @@ -199,6 +199,8 @@ export default { this.basketItems = result.data?.shop?.basket?.items?.values || null; }, addToBasket(lendAmount) { + // emitting updating tools for empty state in checkout page + this.$emit('updating-totals', true); this.isAdding = true; return setLendAmount({ amount: lendAmount, diff --git a/src/components/RandomLoanSelector/RandomLoanSelector.vue b/src/components/RandomLoanSelector/RandomLoanSelector.vue index f725a63b0c..fbd5074918 100644 --- a/src/components/RandomLoanSelector/RandomLoanSelector.vue +++ b/src/components/RandomLoanSelector/RandomLoanSelector.vue @@ -31,6 +31,7 @@ :use-full-width="true" :show-tags="true" :enable-five-dollars-notes="enableFiveDollarsNotes" + @updating-totals="$emit('updating-totals', $event)" @add-to-basket="addToBasket(index)" class="tw-h-full" />