diff --git a/src/components/Lightboxes/AddToBasketInterstitial.vue b/src/components/Lightboxes/AddToBasketInterstitial.vue
index d17c1d625c..780d1bb5e7 100644
--- a/src/components/Lightboxes/AddToBasketInterstitial.vue
+++ b/src/components/Lightboxes/AddToBasketInterstitial.vue
@@ -64,7 +64,7 @@
-
+
Support more loans like {{ loan.loan.name }}
@@ -125,6 +126,7 @@ export default {
loanTotals: '0.00',
loading: true,
showInterstitial: false,
+ showLoansYouMightLike: true,
userPrefHideInterstitial: false,
};
},
diff --git a/src/components/LoansYouMightLike/lymlContainer.vue b/src/components/LoansYouMightLike/lymlContainer.vue
index cf5d8e7cab..ebadaa261d 100644
--- a/src/components/LoansYouMightLike/lymlContainer.vue
+++ b/src/components/LoansYouMightLike/lymlContainer.vue
@@ -222,21 +222,27 @@ export default {
}
},
parseLoansYouMightLike(loansYouMightLike) {
- const withoutBasketedLoans = _filter(
- loansYouMightLike || [],
- loan => this.itemsInBasket.indexOf(loan.id) === -1
- );
+ const filteredLoans = loansYouMightLike.filter(loan => {
+ // sometimes null comes back from the ml service
+ if (loan === null) return false;
+ return this.itemsInBasket.indexOf(loan.id) === -1;
+ });
// Pruning out duplicates among queried loan sets
- const prunedLoansYouMightLike = _uniqBy(withoutBasketedLoans, 'id');
+ const prunedLoansYouMightLike = _uniqBy(filteredLoans, 'id');
// Randomize array order to be displayed in the front end
this.loansYouMightLike = _shuffle(prunedLoansYouMightLike);
// once we have loans flip the switch to show them
- this.showLYML = true;
+ this.showLYML = prunedLoansYouMightLike.length > 0 || false;
this.loading = false;
+ // emit event signifying no recommended loans found
+ if (prunedLoansYouMightLike.length === 0) {
+ this.$emit('no-rec-loans-found');
+ }
+
this.fireExperimentTracking();
// update window width once loans are loaded