fix(ImageCroppingWidget): Missing unsubscribe call

Kitware · Oct 28, 2019 · 211179b · 211179b
1 parent ab83119
commit 211179b
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/Sources/Widgets/Widgets3D/ImageCroppingWidget/index.js b/Sources/Widgets/Widgets3D/ImageCroppingWidget/index.js
@@ -24,6 +24,8 @@ import { ViewTypes } from 'vtk.js/Sources/Widgets/Core/WidgetManager/Constants';
 function vtkImageCroppingWidget(publicAPI, model) {
   model.classHierarchy.push('vtkImageCroppingWidget');
 
+  let stateSub = null;
+
   // --------------------------------------------------------------------------
 
   function setHandlesEnabled(label, flag) {
@@ -87,6 +89,14 @@ function vtkImageCroppingWidget(publicAPI, model) {
     }
   };
 
+  // --------------------------------------------------------------------------
+
+  publicAPI.delete = macro.chain(publicAPI.delete, () => {
+    if (stateSub) {
+      stateSub.unsubscribe();
+    }
+  });
+
   // --- Widget Requirement ---------------------------------------------------
 
   model.behavior = behavior;
@@ -117,7 +127,9 @@ function vtkImageCroppingWidget(publicAPI, model) {
   };
 
   // Update handle positions when cropping planes update
-  model.widgetState.getCroppingPlanes().onModified(publicAPI.updateHandles);
+  stateSub = model.widgetState
+    .getCroppingPlanes()
+    .onModified(publicAPI.updateHandles);
 
   // Add manipulators to our widgets.
   const planeManipulator = vtkPlaneManipulator.newInstance();