[BUG] Access to non-existent MetsDocument property

[beatrycze-volk]

Description

Using the nonexistent MetsDocument property inside the loops. musicalStructureInfo is always null, as it was never defined nor assigned in the class.

This problem appears in few places:

DocumentAnnotation class - foreach ($this->document->getCurrentDocument()->musicalStructureInfo as $key => $musicalInfo)

NavigationController class - $measureOptions[$i] = '[' . $i . ']' . ($this->document->getCurrentDocument()->musicalStructureInfo[$this->document->getCurrentDocument()->musicalStructure[$i]['measureid']]['orderlabel'] ? ' - ' . htmlspecialchars($this->document->getCurrentDocument()->musicalStructureInfo[$this->document->getCurrentDocument()->musicalStructureInfo[$i]]['orderlabel']) : '')

PageViewController class - $musicalStruct = $doc->musicalStructureInfo; -> foreach ($musicalStruct as $measureData)

Reproduction

Steps to reproduce the behaviour:

1. Install TYPO3 11.x with PHP 8.x
2. Click on link to display document page e.g. https://sachsendigital.ddev.site
3. See error

Expected Behavior

The class parameters should be declared and assigned before the usage.

Screenshots and Examples

Environment

• RDBMS version: MariaDB 10.3
• TYPO3 version: 11.5.37
• PHP version: 8.2