tests/cl.filesystem: skip "/run", fix test failure on arm64 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
approved these changes
Jun 8, 2021
|
Maybe fix the sentence by adding gets flagged or what you thought should continue the sentence: … spaces in the filename[, gets flagged] |
On arm64, we have a `/run/udev/data/+platform:Fixed MDIO bus.0`, which gets flagged due to the presence of spaces in the filename. Since /run is an ephemeral directory and we skip other directories (/proc, /sys) for that reason, it seems like a good idea to skip /run as well.
wrl
force-pushed
the
wrl/fix-cl.filesystem-on-arm64
branch
from
13bc2a9 to
2c55059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arm64, we have a
/run/udev/data/+platform:Fixed MDIO bus.0, which, due to the presence of spaces in the filename. Since/runis an ephemeral directory and we skip other directories (/proc,/sys) for that reason, it seems like a good idea to skip/runas well.