From d64934e4fae59bcc9c251c6ca42687b03c3f3d24 Mon Sep 17 00:00:00 2001 From: Iago Lopez Galeiras Date: Mon, 28 Jun 2021 17:01:21 +0200 Subject: [PATCH 1/2] cluster/apply: enable upgrade kubelets by default It has been tested enough and it works reliably. --- cli/cmd/cluster-apply.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/cmd/cluster-apply.go b/cli/cmd/cluster-apply.go index c6d7e08c1..f415cc19b 100644 --- a/cli/cmd/cluster-apply.go +++ b/cli/cmd/cluster-apply.go @@ -51,7 +51,7 @@ func init() { pf.BoolVarP(&skipControlPlaneUpdate, "skip-control-plane-update", "", false, "Skip updating the control plane (not recommended)") - pf.BoolVarP(&upgradeKubelets, "upgrade-kubelets", "", false, "Experimentally upgrade self-hosted kubelets") + pf.BoolVarP(&upgradeKubelets, "upgrade-kubelets", "", true, "Upgrade self-hosted kubelets") } func runClusterApply(cmd *cobra.Command, args []string) { From 01388aa1d965770318907e013f4cb19a90e659be Mon Sep 17 00:00:00 2001 From: Iago Lopez Galeiras Date: Mon, 28 Jun 2021 17:03:14 +0200 Subject: [PATCH 2/2] docs: update cluster apply docs To include the change of default value for --upgrade-kubelets. --- docs/cli/lokoctl_cluster_apply.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/cli/lokoctl_cluster_apply.md b/docs/cli/lokoctl_cluster_apply.md index 63e07a518..571426abe 100644 --- a/docs/cli/lokoctl_cluster_apply.md +++ b/docs/cli/lokoctl_cluster_apply.md @@ -23,7 +23,7 @@ lokoctl cluster apply [flags] --skip-components Skip applying component configuration --skip-control-plane-update Skip updating the control plane (not recommended) --skip-pre-update-health-check Skip ensuring that cluster is healthy before updating (not recommended) - --upgrade-kubelets Experimentally upgrade self-hosted kubelets + --upgrade-kubelets Upgrade self-hosted kubelets (default true) -v, --verbose Show output from Terraform ```