Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex matching not working #181

Open
abhineetgupta opened this issue Mar 16, 2023 · 1 comment
Open

regex matching not working #181

abhineetgupta opened this issue Mar 16, 2023 · 1 comment

Comments

@abhineetgupta
Copy link

Regex pattern matching does not seem to work. Using the same example as in the readme - @.+\.amazon\.co\.uk$, Shopping, and then opening amazon.co.uk in a new tab does not open the link in the Shopping container.

glob matching works fine, so adding !*.amazon.co.uk, Shopping works as expected.

Restarting the browser did not solve the issue.

Tried on Firefox 110.0 and 111.0.
@abhineetgupta
Copy link
Author

abhineetgupta commented Mar 17, 2023 •
edited
Loading

After doing further testing, it appears that the error occurs because there is an extra $ at the end of the url in the readme which is not needed for regex. Only change needed is updating the readme.
Created PR-182 to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhineetgupta