Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLD matching isn't using eTLD, mismatches *.co.uk #159

Open
mook-as opened this issue May 28, 2021 · 3 comments · May be fixed by #192
Open

TLD matching isn't using eTLD, mismatches *.co.uk #159

mook-as opened this issue May 28, 2021 · 3 comments · May be fixed by #192

Comments

@mook-as
Copy link

mook-as commented May 28, 2021

Hi, first, thanks for the extension! I've been using it for quite a while now.

I have a default container rule for ~{domain}.{tld}; however, on https://amazon.co.uk/, that generates a container name of ~co.uk, which isn't quite the desired behaviour. I think that should follow eTLD rules and result in amazon.co.uk, but I'm not sure.

Double checking the implementation, I can confirm that this is an issue from this extension and not part of Firefox.

Thanks!

Using containerise 3.9.0 on Firefox 88.

@ethhics
Copy link
Contributor

ethhics commented Jun 8, 2021

Looks like adding a dependency can fix eTLD support: https://stackoverflow.com/a/61253586

@O-DoC
Copy link

O-DoC commented Aug 17, 2021

Hi,
DiD you have any update on this issue ?
Still the same as OP here too.
version 3.9.0 on FF 90.0.2
Thanks 👍🏽

@rtrind
Copy link

rtrind commented Feb 18, 2022

Also interested on this, it breaks most .com.br addresses and it would solve the need to create containers for one time login access.

@mook mook linked a pull request Apr 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants