-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jquery dependency missing from package.json #31
Comments
…he documentation format.
Fixed. |
thanks for responding so quickly! It looks like that commit removed the package.json file entirely though? |
…he documentation format. mend
My bad, it's up and running again ;) |
thanks! |
I think this should be a peerDependency - otherwise it installs its own local copy of jQuery, which isn't needed and doesn't play nicely with Webpack. import $ from 'jquery';
import 'imports-loader?jQuery=jquery$!jquery.idle';
$(document).idle({ ... }); // TypeError: (...).idle is not a function This is because the plugin loads one copy of jQuery (the one npm installed in Temporary workaround: import $ from 'jquery';
window.jQuery = $;
require('jquery.idle');
delete window.jQuery;
$(document).idle({ ... }); |
Thank you for the suggestion. See the version 1.3.0 |
Thanks @kidh0, that works great. 👍 |
No description provided.
The text was updated successfully, but these errors were encountered: