Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous improvements for 2025-W02 #218

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Miscellaneous improvements for 2025-W02 #218

wants to merge 13 commits into from
+424 −147

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented Jan 9, 2025 •
edited
Loading

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added enh Enhancements & new features data-source Issues related to specific web services/data source(s) labels Jan 9, 2025
@khaeru khaeru self-assigned this Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.69421% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.12%. Comparing base (fc68ccf) to head (bd10375).

Files with missing lines Patch % Lines
sdmx/source/__init__.py 84.61% 2 Missing ⚠️
sdmx/format/xml/common.py 94.73% 1 Missing ⚠️
sdmx/reader/xml/v21.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   98.84%   98.12%   -0.73%     
==========================================
  Files         101      101              
  Lines        8316     8365      +49     
==========================================
- Hits         8220     8208      -12     
- Misses         96      157      +61
Files with missing lines Coverage Δ
sdmx/client.py 96.17% <100.00%> (-1.64%) ⬇️
sdmx/reader/xml/common.py 100.00% <100.00%> (ø)
sdmx/testing/__init__.py 99.20% <100.00%> (+0.15%) ⬆️
sdmx/testing/data.py 100.00% <ø> (ø)
sdmx/tests/format/test_format_xml.py 100.00% <100.00%> (ø)
sdmx/tests/reader/test_reader_xml_v21.py 100.00% <100.00%> (ø)
sdmx/tests/test_source.py 100.00% <100.00%> (ø)
sdmx/tests/test_sources.py 92.71% <100.00%> (-3.18%) ⬇️
sdmx/format/xml/common.py 99.20% <94.73%> (-0.80%) ⬇️
sdmx/reader/xml/v21.py 99.06% <90.00%> (-0.27%) ⬇️
... and 1 more

... and 15 files with indirect coverage changes

khaeru added a commit to khaeru/sdmx-test-data that referenced this pull request Jan 9, 2025
@khaeru
Add real + constructed specimens for khaeru/sdmx#218
4881e40
@khaeru khaeru force-pushed the enh/2025-w02 branch 3 times, most recently from be11183 to fa1bc13 Compare January 10, 2025 17:06
@khaeru
Improve validate_xml()
bd10375 
- Locate schemas in any subdir of `schema_dir` arg.
- Add max_errors parameter.
- Only call XMLSchema.validate() once.
- Don't hard-code valid root elements; interpret the error log.
- Log all messages.
- Adjust tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@khaeru khaeru

Labels
data-source Issues related to specific web services/data source(s) enh Enhancements & new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AR1 (Argentina) data provider Add UY110 (Uruguay) REST data source Add StatCan REST data source
1 participant
@khaeru