From fbc9efaa6fe63ed2d6e42ba52b644079c4f784c5 Mon Sep 17 00:00:00 2001 From: Kyle Farnung Date: Wed, 28 Jun 2017 13:59:14 -0700 Subject: [PATCH] doc: fix broken markdown link * Fixed malformed link * Added link to Homebrew * Updated the build instructions PR-URL: https://github.com/nodejs/node-chakracore/pull/319 Reviewed-By: Kunal Pathak --- README.md | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index 7ae4173c5f4..5375b2f5020 100644 --- a/README.md +++ b/README.md @@ -71,24 +71,23 @@ If you are looking to build this yourself, here's what you will need. Prerequisites: * Windows 7 SP1 or higher (Windows 8.1 or higher for ARM builds) * [Python 2.6 or 2.7](https://www.python.org) -* [Visual Studio] - (https://www.visualstudio.com/en-us/downloads/download-visual-studio-vs.aspx) +* [Visual Studio](https://www.visualstudio.com/en-us/downloads/download-visual-studio-vs.aspx) Build Command: ```batch -vcbuild chakracore nosign [x86|x64|arm] +> vcbuild [x86|x64|arm] ``` To run unit tests ```batch -vcbuild chakracore nobuild test [x86|x64|arm] +> vcbuild nobuild test ignore-flaky [x86|x64|arm] ``` To test if Node.js was built correctly with ChakraCore: ```batch -C:\>node -e "console.log('Hello from Node.js ' + process.jsEngine)" +> node -e "console.log('Hello from Node.js ' + process.jsEngine)" Hello from Node.js chakracore ``` @@ -99,34 +98,34 @@ Clang 3.7+ / CMake 3.2 are required Debian/Ubuntu: ``` -sudo apt-get install -y build-essential cmake clang libicu-dev +$ sudo apt-get install -y build-essential cmake clang libicu-dev ``` Fedora: ``` -su -dnf group install -y "Development Tools" "C Development Tools and Libraries" -dnf install -y git cmake clang gcc gcc-c++ kernel-devel python llvm -dnf install -y lttng-ust-devel.x86_64 libicu-devel.x86_64 libstdc++-static.x86_64 +$ su +$ dnf group install -y "Development Tools" "C Development Tools and Libraries" +$ dnf install -y git cmake clang gcc gcc-c++ kernel-devel python llvm +$ dnf install -y lttng-ust-devel.x86_64 libicu-devel.x86_64 libstdc++-static.x86_64 ``` Clone this repo and check out **`master`** branch: ``` -git checkout master +$ git checkout master ``` Build: ``` -./configure -make +$ ./configure +$ make ``` To run unit tests: ``` -$ make test +$ FLAKY_TESTS=dontcare make test ``` To test if Node.js was built correctly with ChakraCore: @@ -140,7 +139,7 @@ Hello from Node.js chakracore Prerequisites: * XCode v7 or higher -* Homebrew +* [Homebrew](https://brew.sh/) Install the building tools: