Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk cache cleanup needs to disable when there's no upstream #7

Open
kf6kjg opened this issue Jan 2, 2018 · 1 comment
Open

Disk cache cleanup needs to disable when there's no upstream #7

kf6kjg opened this issue Jan 2, 2018 · 1 comment
Labels
Milestone

Comments

@kf6kjg
Copy link
Owner

kf6kjg commented Jan 2, 2018

If there's no upstream asset server to forward assets to, then the server is implicitly in asset server mode - as opposed to asset cache mode. Thus it should be allowed to progress until it's taken over the disk array.

Maybe users should be warned? Maybe refuse to run if there's no upstream and limits have been set? That would imply being able to remove disk consumption limits...

EDIT: Why is disk cache cleanup a problem in this case? Because it means those assets will have been permanently deleted from the grid: no other server has them because there's no upstream server to forward them to.

@kf6kjg kf6kjg added this to the V1.0 milestone Feb 18, 2018
@kf6kjg kf6kjg added the bug label Feb 18, 2018
@kf6kjg
Copy link
Owner Author

kf6kjg commented Apr 7, 2018

The goal has shifted: the code should be changed so the single-db LMDB edition is allowed to grow across multiple files like it's designed to do and block purging. The code should then be refactored to use the most relevant storage engine based on config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant