Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(common/models): LM replaces left quote and character(s) with the selected option #6900

Closed
MakaraSok opened this issue Jun 30, 2022 · 5 comments · Fixed by #7205
Closed

bug(common/models): LM replaces left quote and character(s) with the selected option #6900

MakaraSok opened this issue Jun 30, 2022 · 5 comments · Fixed by #7205
Assignees
@jahorton
Labels
bug common/models/ common/
Milestone
A17S27

Comments

@MakaraSok
Copy link
Collaborator

lm.replace.quote.and.character.typed.with.the.selected.suggestion.mov

The clip above shows that the left quote and a character being typed get replaced with the word selected off of the suggestion banner.

This behavior is not unique to the language script being used. EuroLatin (SIL) keyboard also exhibits this behavior when testing on mobile devices, i.e. iOS and Android. In the Keyman app with the default keyboard on, type a double quote " and then t, now select the of of the suggestion banner to see that the replace both " and t.
@DavidLRowe
Copy link
Contributor

@mcdurdin Is this something that should be fixed in keyboards? or Keyman for iOS/Android? or some combination?

And is issue keymanapp/lexical-models#171 related to this issue?

@mcdurdin
Copy link
Member

mcdurdin commented Jul 5, 2022

@jahorton any thoughts?

@jahorton jahorton transferred this issue from keymanapp/lexical-models Jul 6, 2022
@jahorton jahorton changed the title LM replaces left quote and character(s) with the selected option bug(common/models): LM replaces left quote and character(s) with the selected option Jul 6, 2022
@mcdurdin mcdurdin added this to the A16S7 milestone Jul 21, 2022
@mcdurdin mcdurdin modified the milestones: A16S7, A16S8 Aug 7, 2022
@mcdurdin mcdurdin modified the milestones: A16S8, A16S9 Aug 19, 2022
@mcdurdin mcdurdin modified the milestones: A16S9, A16S10 Sep 5, 2022
@jahorton jahorton mentioned this issue Sep 5, 2022
Merged
@jahorton jahorton mentioned this issue Sep 6, 2022
Merged
@jahorton
Copy link
Contributor

Possible duplicate of #6024? In which case, the mentioned #7205 probably fixes that too.

@MakaraSok MakaraSok reopened this May 11, 2023
@MakaraSok
Copy link
Collaborator Author

Tested with Keyman for iOS 17.0.104-alpha on iOS 16.4 on iPhone 14 Pro Max Simulator
https://github.com/keymanapp/keyman/assets/28331388/20387f09-506b-4e4f-81be-31aa3c43ca23

@MakaraSok MakaraSok mentioned this issue Dec 8, 2023
Open
8 tasks
@mcdurdin mcdurdin removed this from the A16S10 milestone Aug 6, 2023
@mcdurdin mcdurdin added this to the A17S22 milestone Aug 18, 2023
@mcdurdin mcdurdin modified the milestones: A17S22, A17S23 Oct 1, 2023
@mcdurdin mcdurdin modified the milestones: A17S23, A17S24 Oct 15, 2023
@mcdurdin mcdurdin modified the milestones: A17S24, A17S25 Oct 27, 2023
@mcdurdin mcdurdin modified the milestones: A17S25, A17S26 Nov 13, 2023
@darcywong00 darcywong00 modified the milestones: A17S26, A17S27 Nov 27, 2023
@jahorton jahorton closed this as completed Dec 4, 2023
@jahorton
Copy link
Contributor

jahorton commented Dec 4, 2023

See keymanapp/lexical-models#230; the issue is with the model, not KMW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jahorton jahorton

Labels
bug common/models/ common/
Projects
None yet
Milestone
A17S27
Development

Successfully merging a pull request may close this issue.

fix(common/models): fixes quote-adjacent pred-text suggestions keymanapp/keyman
5 participants
@mcdurdin @darcywong00 @DavidLRowe @jahorton @MakaraSok