Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Update system keyboard height consistently #13273

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix(android): Update system keyboard height consistently #13273

merged 1 commit into from
Feb 21, 2025

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Feb 18, 2025 •
edited
Loading

Fixes #13245 and follows #11604 in the long line of changes to fix OSK height after an orientation change (portrait <--> landscape)

This moves the SystemKeyboard orientation update from onStartInput() (init only) to onComputeInsets() where it's consistently called on configuration changes.

User Testing

Setup - Install the PR build of Keyman for Android.

  • TEST_OSK_HEIGHT_AFTER_ADJUSTING - Verifies system keyboard OSK height is correct after adjusting the height and rotating
  1. Launch the Keyman app in portrait view.
  2. The "Get Started" menu appears, enable Keyman as a system keyboard and set it as the default keyboard.
  3. Resize the keyboard height by choosing Keyman settings --> Adjust keyboard height
  • adjust the height
  • back to the Keyman app
  1. Rotate the mobile device from portrait view to landscape view.
  2. Resize the keyboard height by choosing Keyman settings --> Adjust keyboard height
  • adjust the height
  • back to the Keyman app
    6.Verify the keyboard height in landscape view matches the setting.
  1. Rotate the mobile device from landscape view to portrait view.
  2. Open the Chrome app and then navigate to the Google search box.
  3. Click in the search box.
  4. Verify the keyboard height matches the adjusted portrait height.

@darcywong00 darcywong00 added this to the B18S2 milestone Feb 18, 2025
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Feb 18, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 18, 2025 •
edited
Loading

User Test Results

Test specification and instructions

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Feb 18, 2025
@darcywong00 darcywong00 linked an issue Feb 18, 2025 that may be closed by this pull request
bug(android): The keyboard size does not display in full view when resizing the keyboard height. #13245
Closed
8 tasks
@dinakaranr
Copy link

Test Results

I tested this issue with the attached Keyman"18.0.195-beta-test-13273" build(18/02/2025) on Android 14 and Android 12 API 31(emulator). Here I am sharing my observation.

  • TEST_OSK_HEIGHT_AFTER_ADJUSTING (Passed):
  1. Installed the keyman-18.0.192-beta.apk file
  2. Launch the Keyman app in portrait view.
  3. The "Get Started" menu appears, enable Keyman as a system keyboard and set it as the default keyboard.
  4. Resize the keyboard height by choosing Keyman settings --> Adjust keyboard height
  • adjust the height
  • back to the Keyman app
  1. Rotate the mobile device from portrait view to landscape view.
  2. Resize the keyboard height by choosing Keyman settings --> Adjust keyboard height
  • adjust the height
  • back to the Keyman app
  1. Verified that the keyboard height in landscape view matches the setting.
  2. Rotate the mobile device from landscape view to portrait view.
  3. Open the Chrome app and then navigate to the Google search box.
  4. Click in the search box.
  5. Verified the keyboard height matches the adjusted portrait height.
    It works well. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Feb 18, 2025
@darcywong00 darcywong00 merged commit 9712e3b into beta Feb 21, 2025
6 checks passed
@darcywong00 darcywong00 deleted the fix/android/adjust-osk-height-rotate branch February 21, 2025 06:34
@darcywong00 darcywong00 mentioned this pull request Feb 21, 2025
Closed
8 tasks
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.198-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@sgschantz sgschantz Awaiting requested review from sgschantz sgschantz is a code owner

Assignees
No one assigned
Labels
android/app/ android/ fix has-user-test
Projects
Keyman
Archived in project
Milestone
B18S2
Development

Successfully merging this pull request may close these issues.

bug(android): The keyboard size does not display in full view when resizing the keyboard height.
4 participants
@darcywong00 @dinakaranr @keyman-server @mcdurdin