Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Fix failing builds with current nitro version #4

Closed
itpropro opened this issue Oct 22, 2022 · 0 comments · Fixed by #5
Closed

Fix failing builds with current nitro version #4

itpropro opened this issue Oct 22, 2022 · 0 comments · Fixed by #5
Assignees

Comments

@itpropro
Copy link
Collaborator

itpropro commented Oct 22, 2022

A current nitro project cannot be compiled because of the dependency to h3 0.7.21. h3 had breaking chages with 0.8.0, which leads to compilation errors:

import { eventHandler, setHeaders, sendRedirect, defineEventHandler, handleCacheHeaders, createEvent, getRequestHeader, createError, createApp, createRouter as createRouter$1, lazyEventHandler, toNodeListener } from 'h3';
                                                                                                                                                                                                   ^^^^^^^^^^^^^^
SyntaxError: The requested module 'h3' does not provide an export named 'toNodeListener'

We should at least update the dependency to 0.8.0 and continuously update the h3 dependency until it reaches 1.0.0 in CI/CD. Maybe add renovate to stay up to date?

PS: @kevinmarrec can you add the hacktoberfest label to the repo? Contributions can then be added to the contributors hacktoberfest score :)

@itpropro itpropro changed the title Update h3 dependencies Fix failing builds with current nitro version Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant