Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using Double as underlying storage #55

Open
kevincianfarini opened this issue Jan 8, 2025 · 3 comments
Open

Consider using Double as underlying storage #55

kevincianfarini opened this issue Jan 8, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@kevincianfarini
Copy link
Owner

kevincianfarini commented Jan 8, 2025 •
edited
Loading

It's a choice between this and #13
@kevincianfarini
Copy link
Owner Author

Here's why Duration didn't use it. Kotlin/KEEP#190 (comment)

@kevincianfarini
Copy link
Owner Author

It's also worth considering the viability of having everything stored as value classes.

@kevincianfarini kevincianfarini added the enhancement New feature or request label Jan 15, 2025
@kevincianfarini kevincianfarini mentioned this issue Jan 15, 2025
Open
@sargunv
Copy link

sargunv commented Jan 27, 2025 •
edited
Loading

Imo it's good to have the predictable behavior of integer storage. But the downside is we can't have units not divisible by nanoWhatever represented exactly (probably not a big deal?).

If there's use cases for floating point storage, perhaps those would be new quantity types? FloatingLength and so on, like Double vs Long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sargunv @kevincianfarini