Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The system namespace is visible even when listing "User" flows #5226

Closed
loicmathieu opened this issue Sep 30, 2024 · 7 comments · Fixed by #5403
Closed

The system namespace is visible even when listing "User" flows #5226

loicmathieu opened this issue Sep 30, 2024 · 7 comments · Fixed by #5403
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working

Comments

@loicmathieu
Copy link
Member

Describe the issue

The system namespace is visible even when listing "User" flows.
Capture d’écran du 2024-09-30 11-12-01

This leads to an empty list of flows when selecting it.
Capture d’écran du 2024-09-30 11-08-05

So we had to un-check USER type of flow to list the system flows
Capture d’écran du 2024-09-30 11-08-14

Environment

  • Kestra Version: 0.19.0-SNAPSHOT
  • Operating System (OS/Docker/Kubernetes):
  • Java Version (if you don't run kestra in Docker):
@loicmathieu loicmathieu added bug Something isn't working area/frontend Needs frontend code changes labels Sep 30, 2024
@Mahitej28
Copy link

Mahitej28 commented Oct 1, 2024

@loicmathieu, can I work on this issue under hacktoberfest'24... also let me know what's need to be done for the same.

@loicmathieu
Copy link
Member Author

@Mahitej28 you can work on the issue but I'm not sure what needs to be done, if you didn't find it by yourself maybe find an easier issue to work on.

@Mahitej28
Copy link

Okay will have a look

@MilosPaunovic MilosPaunovic self-assigned this Oct 2, 2024
@MilosPaunovic
Copy link
Member

@Mahitej28 But if you're up for a try, please go ahead! 🚀

@MilosPaunovic
Copy link
Member

It's true that a current solution feels a bit weird, but it's intended behavior.

We could amend it in two ways:

  1. Don't show system in the namespace filter options.
  2. If selecting system namespace as a filter option, we remove the User Flows and add System Flows filter, which can lead to more confusion as that way we'd be changing filters for user in way it's not expected.

I would prefer either first option or leaving it as is now. WDYT @Ben8t?

@Ben8t
Copy link
Member

Ben8t commented Oct 4, 2024

  1. Don't show system in the namespace filter options.

Seems the good solution for now. system is a "protected" namespace name (hence the filter User vs System).

Please take account that it can be configurable:

kestra:
  system-flows:
    namespace: system

So we should filter on this namespace value

@MilosPaunovic
Copy link
Member

I have filtered out system namespace on NS selection filter component we're using throughout the project in this PR, but we definitely need to tackle this issue to have everything handled in a proper way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants