Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP client with client-id does not work #899

Closed
troglobit opened this issue Jan 20, 2025 · 0 comments · Fixed by #887
Closed

DHCP client with client-id does not work #899

troglobit opened this issue Jan 20, 2025 · 0 comments · Fixed by #887
Assignees
Labels
bug Something isn't working
Milestone

Comments

@troglobit
Copy link
Contributor

Current Behavior

Setting up a DHCP client with client ID does not work:

  1. The format of option 61 is missing the htype
  2. The payload of option 61 is cut short

Example:

  "infix-dhcp-client:dhcp-client": {
    "client-if": [
      {
        "if-name": "e5",
        "client-id": "xyzzy"
      }
    ]
  },

The resulting option 61 is encoded as: [ 61 | 03 | 78 | 79 | 7a ]

Expected Behavior

The resulting option 61 is encoded as: [ 61 | 06 | 00 | 78 | 79 | 7a | 7a | 79 ]

Steps To Reproduce

No response

Additional information

No response

@troglobit troglobit added bug Something isn't working triage Pending investigation & classification (CCB) labels Jan 20, 2025
@troglobit troglobit self-assigned this Jan 20, 2025
@troglobit troglobit removed the triage Pending investigation & classification (CCB) label Jan 20, 2025
@troglobit troglobit added this to the Infix v25.01 milestone Jan 20, 2025
@troglobit troglobit moved this to In progress in Infix & C:o Jan 20, 2025
troglobit added a commit that referenced this issue Jan 20, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 21, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 26, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 27, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 27, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 27, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 28, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 28, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 30, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 30, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 31, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Jan 31, 2025
Fixes #899

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit linked a pull request Jan 31, 2025 that will close this issue
17 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in Infix & C:o Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant