Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Allow import of all files in a directory to the job container #29

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Allow import of all files in a directory to the job container #29

merged 3 commits into from
Jun 24, 2021

Conversation

botchk
Copy link
Collaborator

@botchk botchk commented Jun 23, 2021

Single files or all files in a directory can be added to your running tasks by specifying them in the files section of
your tasks:

files:
  - locust/basic.py
  - locust/import.py
  - locust/locust.conf
  - /helm

The above settings will make the listed single files and all files in the helm directory and its subdirectories
available in your task. Files can be listed with or without a starting /, it will be handled as absolute path for both
cases.

Other

  • Added more information to some error messages

@botchk botchk added documentation Improvements or additions to documentation type:feature New feature or request that provides value to the stakeholders/end-users go Pull requests that update Go code labels Jun 23, 2021
@botchk botchk added this to the 0.1.2 milestone Jun 23, 2021
@botchk botchk requested a review from didiladi June 23, 2021 11:16
@botchk botchk linked an issue Jun 23, 2021 that may be closed by this pull request
Specifying a directory under files should import all files of this directory #28
Closed
@botchk
Copy link
Collaborator Author

botchk commented Jun 23, 2021

Based on feature/#18/configurable-resource-quotas, pls review and merge that one first

Base automatically changed from feature/#18/configurable-resource-quotas to main June 23, 2021 14:51
@botchk botchk force-pushed the feature/28/allow-import-of-all-files-in-directories branch from c8e3cff to 4e6689b Compare June 23, 2021 14:57
@github-actions
Copy link
Contributor

The following Docker Images have been built:

  • Pushed keptnsandbox/job-executor-service:0.1.2-dev-PR-29.202106231607 and keptnsandbox/job-executor-service:0.1.2-dev-PR-29 (Source: ./)
  • Pushed keptnsandbox/job-executor-service-initcontainer:0.1.2-dev-PR-29.202106231607 and keptnsandbox/job-executor-service-initcontainer:0.1.2-dev-PR-29 (Source: ./)

@didiladi
Copy link
Collaborator

Thx for adding the test! 💪 🚀

@botchk botchk merged commit 1affbfe into main Jun 24, 2021
@botchk botchk deleted the feature/28/allow-import-of-all-files-in-directories branch September 14, 2021 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@didiladi didiladi didiladi approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation go Pull requests that update Go code type:feature New feature or request that provides value to the stakeholders/end-users
Projects
None yet
Milestone
0.1.2
Development

Successfully merging this pull request may close these issues.

Specifying a directory under files should import all files of this directory
2 participants
@botchk @didiladi